So this blog pretty much covers everything about the process and commands which I follow for the practical session of my Linux kernel first patch workshop.
I usually prefer to go for the simple syntax errors [suggested by checkpatch.pl] for the first patch practice. Also, usually it’s a good idea to send clean up patches for the files in staging directory only. Specifically when you are newbie and sending a patch in a kernel for the 1st time.
Note that this is just a list of commands, for more detailed versions and things I explained, you can refer to the slides and first patch tutorial. Also, make sure to run all of these commands under the source code directory of the Linux kernel and where Makefile resides. Do not run these commands under specific directories.
Run checkpatch.pl over the directory of your choice under the staging to edit a file.
perl scripts/checkpatch.pl -f drivers/staging/media/bcm2048/* | less
Check the code. Use following command to see who did that change and why. This is
useful in a practice to understand the approach of a code author.
git blame -L x,y file_path.c // x,y specifies the Line numbers
e.x git blame -L 30,32 filr_path.c
This will give you a list of commits. You can use ‘git show <commit id>’ to check the
Once done with changing the code, compile the file. It should produce the .o file without any errors.
Sometimes you may want to run ‘make file_path/’. For example, you can run ‘make drivers/staging/media/bcm2048/’ .
If the file successfully compiles then go for creating a patch. For that, first
add your changes in a git.
Git add <file_path>
Now, create a commit.
Git commit -s -v
-s adds signed off by line and -v adds git diff in the commit you are creating.
You can read about the patch philosophy over here. For the patch best practices, refer to patch philosophy.
Create a patch now.
Git format-patch -o /tmp/ HEAD^
This will give you temporary .patch file. ex.
In the LKML, we prefer that new patches should not introduce any syntax warnings.
So, run checkpatch.pl over your temp .patch file. And solve sytax errors if there
scripts/checkpatch.pl <.patch file>
Get the list of maintainers and mailing lists to send that patch.
git show HEAD | perl scripts/get_maintainer.pl –separator , –nokeywords –nogit –nogit-fallback –norolestats –nol
Send the patch using git send-email.
git send-email –to= –cc= <.patch file>
To setup git send-email you can go for this blog post.
Also, few other commands which I use while giving first patch workshops are here:
To check the modified file:
git status and git diff
To check the commit after creating it.
I’ll write separate posts explaining what to do when going for the v2 of the